- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
general improvements/fixes on bootstrap #118220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | (rustbot has picked a reviewer for you, use r? to override) | 
| This PR changes  | 
a7dcb98    to
    e260563      
    Compare
  
    | @bors r+ rollup | 
Signed-off-by: onur-ozkan <[email protected]>
This fixes the problem of not being able to see bootstrap config changes unless the change-id in config.toml changes. Signed-off-by: onur-ozkan <[email protected]>
Because bootstrap lib is already large and complicated, this should make the "bumping change-id" process easier. Signed-off-by: onur-ozkan <[email protected]>
e260563    to
    576a17e      
    Compare
  
    | (resolved conflicts) @bors r=Mark-Simulacrum | 
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Nov 25, 2023 
    
    
      
  
    
      
    
  
Rollup of 9 pull requests Successful merges: - rust-lang#118220 (general improvements/fixes on bootstrap) - rust-lang#118251 (rustdoc-search: avoid infinite where clause unbox) - rust-lang#118253 (Replace `option.map(cond) == Some(true)` with `option.is_some_and(cond)`) - rust-lang#118255 (Request that rust-analyzer changes are sent upstream first if possible) - rust-lang#118259 (Move EagerResolution to rustc_infer::infer::resolve) - rust-lang#118262 (Relate Inherent Associated Types using eq) - rust-lang#118266 (Move stuff around on `stable_mir` and `rustc_smir` crate) - rust-lang#118271 (Separate `NaN`/`Inf` floats with `_`) - rust-lang#118274 (Fix smir's `Ty::Ref` pretty printing) r? `@ghost` `@rustbot` modify labels: rollup
    
  rust-timer 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Nov 25, 2023 
    
    
      
  
    
      
    
  
Rollup merge of rust-lang#118220 - onur-ozkan:followups, r=Mark-Simulacrum general improvements/fixes on bootstrap - adds rust-lang#117813 into change tracker rust-lang@6d9b92f - fixes a bug in change tracker rust-lang@63a4410 - relocates `CONFIG_CHANGE_HISTORY` rust-lang@a7dcb98
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    A-meta
  Area: Issues & PRs about the rust-lang/rust repository itself 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-bootstrap
  Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
if-availablevalue ofdownload-ci-llvm#117813 into change tracker 6d9b92fCONFIG_CHANGE_HISTORYa7dcb98